[Bug 516516] Review Request: globus-gridftp-server-control - Globus Toolkit - Globus GridFTP Server Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516516


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |steve.traylen at cern.ch
         AssignedTo|nobody at fedoraproject.org    |steve.traylen at cern.ch
               Flag|                            |fedora-review+




--- Comment #1 from Steve Traylen <steve.traylen at cern.ch>  2009-10-14 17:06:07 EDT ---
Review of globus-gridftp-server-control:

koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1746671


MUST:

no: 
$ rpmlint globus-gridftp-server-control.spec
../SRPMS/globus-gridftp-server-control-0.36-1.fc11.src.rpm
../RPMS/x86_64/globus-gridftp-server-control-*
globus-gridftp-server-control-debuginfo.x86_64: E: description-line-too-long
This package provides debug information for package
globus-gridftp-server-control.
globus-gridftp-server-control-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 1 errors, 1 warnings.

which is fine 
yes: Package name - globus guidelines
yes: Spec File name - globus guidelines
yes: Packaging guidelines
yes: Apache 2.0
yes: .spec ASL 2.0
yes: GLOBUS_LICENSE included.
yes: american english.
yes: Upstream source matches.
$ diff -r --brief
gt4.2.1-all-source-installer/source-trees/gridftp/server-lib/src
~/rpmbuild/SOURCES/globus_gridftp_server_control-0.36
Only in /home/steve/rpmbuild/SOURCES/globus_gridftp_server_control-0.36:
GLOBUS_LICENSE


which is expected.

yes: builds as per koji build above.
yes: locales not present.
yes: Calls ldconfig appropriate
yes: No system libs included.
yes: not relocatable.
yes: All files and directories created in the package are owned.
yes: files not listed twice.
yes: defattr used everywhere.
yes: Buildroot is removed in %clean.
yes: consistant macros
yes: no large docs.
yes: docs not needed runtime.
yes: headers in -devel file.
yes: libs correctly in -devel package.
yes: main package is needed by devel package.
yes: no .la files present.
yes: no gui.
yes: does not own files belonging to other packages.
yes: buildroot removed in %install.
yes: utf8

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.