[Bug 526351] Review Request: tito - A tool for managing rpm based git projects

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526351


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review+




--- Comment #3 from Martin Gieseking <martin.gieseking at uos.de>  2009-10-17 05:33:39 EDT ---
Here's my full review. The package looks fine now.

$ rpmlint /var/lib/mock/fedora-11-x86_64/result/tito-*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.


---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.

[+] MUST: The spec file name must match the base package %{name}.

[+] MUST: The package must meet the Packaging Guidelines.

[+] MUST: The package must be licensed with a Fedora approved license.
    - GPLv2 according to COPYING/LICENSE and source file headers

[+] MUST: The License field in the package spec file must match the actual
license.

[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.

[+] MUST: The spec file must be written in American English.

[+] MUST: The spec file for the package MUST be legible.

[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
    $ sha1sum tito-0.1.1.tar.gz*
    2aa072b6da5edf61bd1125db34067316b54540cb  tito-0.1.1.tar.gz
    2aa072b6da5edf61bd1125db34067316b54540cb  tito-0.1.1.tar.gz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    - noarch package
    - koji scratch build:
      http://koji.fedoraproject.org/koji/taskinfo?taskID=1751306

[.] MUST: If the package does not successfully compile, build or work ...

[+] MUST: All build dependencies must be listed in BuildRequires.

[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
    - no locales 

[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
    - no shared libs

[.] MUST: If the package is designed to be relocatable, ...
    - not relocatable

[+] MUST: A package must own all directories that it creates.

[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.

[+] MUST: Permissions on files must be set properly.

[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.

[+] MUST: Each package must consistently use macros.

[+] MUST: The package must contain code, or permissable content.

[.] MUST: Large documentation files must go in a -doc subpackage.
    - no large docs 

[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.

[.] MUST: Header files must be in a -devel package.
    - no header files

[.] MUST: Static libraries must be in a -static package.
    - no static libs

[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
    - no .pc files

[.] MUST: .so files (without suffix) must go in a -devel package.
    - no shared libs

[.] MUST: devel packages must require the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}

[.] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.

[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
    - no GUI

[+] MUST: Packages must not own files or directories already owned by other
packages.

[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.

[+] MUST: All filenames in rpm packages must be valid UTF-8.

[+] MUST: Python eggs must be built from source. They cannot simply drop an egg
from upstream into the proper directory.

[+] MUST: Python eggs must not download any dependencies during the build
process.

[+] MUST: If egg-info files are generated by the modules build scripts they
must be included in the package.

[.] MUST: When building a compat package, it must install using easy_install -m
so it won't conflict with the main package.

[.] MUST: When building multiple versions (for a compat package) one of the
packages must contain a default version that is usable via "import MODULE" with
no prior setup. 

[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.

[+] SHOULD: The reviewer should test that the package functions as described.

[.] SHOULD: If scriptlets are used, those scriptlets must be sane.

[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.

[.] SHOULD: pkgconfig(.pc) should be placed in a -devel pkg. 


------------------------
The package is APPROVED.
------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.