[Bug 516519] Review Request: globus-gram-client - Globus Toolkit - GRAM Client Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516519


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |steve.traylen at cern.ch
         AssignedTo|nobody at fedoraproject.org    |steve.traylen at cern.ch
               Flag|                            |fedora-review+

Bug 516519 depends on bug 516518, which changed state.

Bug 516518 Summary: Review Request: globus-gram-protocol - Globus Toolkit - GRAM Protocol Library
https://bugzilla.redhat.com/show_bug.cgi?id=516518

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Resolution|                            |ERRATA
             Status|ASSIGNED                    |CLOSED



--- Comment #1 from Steve Traylen <steve.traylen at cern.ch>  2009-10-17 22:34:12 EDT ---
Review: globus-gram-client

Koji Build: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=1752397

YES: rpmlint
$ rpmlint globus-gram-client.spec \
  ../SRPMS/globus-gram-client-7.2-1.fc11.src.rpm \
  ../RPMS/x86_64/globus-gram-client-* \
   ../RPMS/noarch/globus-gram-client-doc-7.2-1.fc11.noarch.rpm 
globus-gram-client-devel.x86_64: W: no-documentation
5 packages and 1 specfiles checked; 0 errors, 1 warnings.

fine.

YES: package name,
YES: spec file name
YES: globus package guidelines.
YES: Yes ASL2.0
YES: GLOBUS_LICENSE included.
YES: English specfiel
YES: Legible specfile.
YES: Source matches upstream
$ diff -r --brief globus_gram_client-7.2
~/globus/src/gt4.2.1-all-source-installer/source-trees/gram/client/source 
Only in globus_gram_client-7.2: GLOBUS_LICENSE

which is expected.
YES: builds see koji build above.
YES: builds on all archs - koji.
YES: BuildRequires are sane.
YES: No locales.
YES: ldconfig called
YES: Not relocatable.
YES: Owns directories.
YES: no duplicate files.
YES: all perms are defattr
YES: buildroot removed in %clean.
YES: Docs are in a doc package.
YES: %doc not needed at runtime.
YES: headers in devel package
YES: No static libs.
YES: requires pkgconfig
YES: devel requires base package.
YES: No .la files.
YES: Does not own files from another package.
YES: buildroot removed in %install
YES: utf8

All good APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.