[Bug 529466] Review Request: linbox - C++ Library for High-Performance Linear Algebra

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529466





--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-10-18 04:03:16 EDT ---
(In reply to comment #4)
> Some quick comments.
> 
>  Either (1) Add the following to the spec -- Do we need to make a separate
> tarball? or (2) notify upstream to have the licencing headers attached. If you
> do notify upstream, I note that some headers are LGPLv2+ -- would upstream be
> able to specify LGPLv2+ to all code?

This is really not necessary. Licensing and copyright are wholly different
things. When some of the files that are included don't specify a license that
they're under, it is assumed that they are under the license of COPYING.
(IANAL, though.)

See the order of operations at
http://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F

In this case the attached COPYING is a generic LGPLv2 COPYING without an
author's specification of which version is to be used, thus the license tag for
the files without a license statement is LGPLv2+.

However, you should still contact upstream and ask them to add the missing
license headers, which makes things easier for everybody.

> linbox.i386: E: shlib-with-non-pic-code /usr/lib/liblinboxsage.so.0.0.0
> linbox.i386: W: shared-lib-calls-exit /usr/lib/liblinboxsage.so.0.0.0
> exit at GLIBC_2.0
> linbox.i386: E: shlib-with-non-pic-code /usr/lib/liblbdriver.so.0.0.0
> linbox.i386: W: shared-lib-calls-exit /usr/lib/liblbdriver.so.0.0.0
> exit at GLIBC_2.0
> 4 packages and 0 specfiles checked; 2 errors, 2 warnings.  

Calling exit happens quite a lot with scientific libraries. To fix the non-pic
code error just add -fPIC to %{optflags}.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.