[Bug 507697] Review Request: python-migrate0.5 - schema migration tools for SQLAlchemy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507697





--- Comment #12 from Alan Pevec <apevec at redhat.com>  2009-10-18 08:09:50 EDT ---
Getting back to this review, scratch EPEL build worked:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1745762

* in PKG-INFO there's License: MIT which is enough, but packager SHOULD query
upstream to include the license text file

* there's typo in %description:
 %description
 Schema migration tools for SQLAlchemy designed to support an agile approach
 to database design and make it easier to keep development and production
-databases in sync as schema changes are required.  It allows you to manage 
-atabase change sets and database repository versioning.
+databases in sync as schema changes are required.  It allows you to manage
+database change sets and database repository versioning.

* in python_sitelib definition, %global should be used instead of %define:
https://fedoraproject.org/wiki/Packaging/Python#System_Architecture

* rpmlint complaints:
[1] python-migrate0.5.noarch: E: script-without-shebang
/usr/lib/python2.4/site-pack
ages/sqlalchemy_migrate-0.5.3-py2.4.egg/migrate/changeset/__init__.py
...(for all .py files in python_sitelib)
[2] python-migrate0.5.noarch: E: zero-length
/usr/lib/python2.5/site-packages/easy-install.pth
[3] python-migrate0.5.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/sqlalchemy_migrate-0.5.3-py2.5.egg/migrate/versioning/templates/manage.py_tmpl
0644 /usr/bin/env


ad [1] if easy_install cannot be made to install modules with 644, workaround
could be to use defattr:

+%defattr(0644,root,root,0755)
 %{python_sitelib}/*

ad [2] there's touch easy-install.pth in spec, removing it avoids this and
easy_install still works fine

ad [3] .py_templ should probably be moved to docs and marked %doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.