[Bug 526916] Review Request: liborc - The Oil Runtime Compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526916





--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de>  2009-10-18 13:41:54 EDT ---
Fabian, I just had another look into your package and found a couple of issues
that should also be addressed:

- you can drop pkgconfig and autoconf from BuildRequires

- remove %makeinstall 

- replace pkg-config by pkgconfig

- replace "rm -Rf" by "rm -rf"

- I suggest to replace %{_includedir}/* by %{_includedir}/%{name}-0.4/ to make
clear that the header files go to a subfolder

- add the doc files COPYING README to the base package and drop them from tools
(even if rpmlint will print a warning about missing docs)

- I suggest to add the compiler orcc to the devel package in order to remove
the tools subpackage, since orcc is also a development tool, and it's a bit of
overhead to create a separate package for just one small additional file. 

- the documentation is quite extensive so it's probably a good idea to put it
into a doc subpackage

- Could you explain the need for the .conf file? As far as I can see, it's not
necessary

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.