[Bug 516521] Review Request: globus-mp - Globus Toolkit - Message Passing Library

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 19 11:22:31 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516521





--- Comment #7 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-10-19 07:22:27 EDT ---
(In reply to comment #6)
> "Install license file" looks bad...
> 
> What about a
> 
> %doc GLOBUS_LICENSE
> 
> instead of 
> 
> %doc %{_docdir}/%{name}-%{version}/GLOBUS_LICENSE
> 
> ?  

Using %doc on a non-installed file implies an implicit rm -rf on the doc
directory. For this particular package that lacks doxygen documentation in the
sources this would be harmless since there are no files installed there, but
this is not the case for properly documented Globus packages. In order to
decrease the effort needed to maintain the Globus packages the differences
between the specfiles for the different packages should be kept at a minimum.
For this reason the lines in the specfile that are responsible for the
packaging of the license file is kept the same for all Globus packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list