[Bug 498218] Review Request: picturetile - Tiles a bunch of images into one large "photo wall"

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 19 20:19:41 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498218


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cwickert at fedoraproject.org




--- Comment #3 from Christoph Wickert <cwickert at fedoraproject.org>  2009-10-19 16:19:39 EDT ---
(In reply to comment #2)
> Just a few comments, not a review:
> 
> This bug should block your tracker bug and not depend on it.

I think what Edwin wants to point out it that first the bug with fspot should
be fixed before he will maintain this package. Edwin, am I correct?

> Are you sure about the version generation?
> See [1]. So it should have the name picturetile-0-1.20050314.fc10.src.rpm,
> isn't it?
> I'm not sure about this, too, but simply using the date as a version number
> 'looks bad'.^^
...
> [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease  

This applies to numeric releases with characters such as "RC", "BETA" and so
on. The date *is* numeric. As time moves forward *hint* *hint* the version will
always increase. So using the date is ok.

However prefixing it with a 0. is not a bad idea. Otherwise we might get into
trouble if upstream one day decides to switch to another versioning.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list