[Bug 529861] Review Request: userspace-rcu - RCU (read-copy-update) in user space

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529861





--- Comment #1 from Dan Horák <dan at danny.cz>  2009-10-21 06:48:54 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     a2f7d4813515d8c510163b84cbbf8cd5d8e177ca  userspace-rcu-0.2.4.tar.bz2
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
BAD license field matches the actual license.
OK license is open source-compatible (LGPLv2+). License text is included
upstream.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
BAD rpmlint is silent.
OK final provides and requires look sane.
BAD %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in -devel.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- the license is right, but the value of the tag should be LGPLv2+, see
https://fedoraproject.org/wiki/Licensing for more details
- the license texts (*.txt) and the licensing "manual" (LICENSE) are included
in the source archive and they must be included in the package as %doc
- rpmlint complains a bit:
userspace-rcu-debuginfo.x86_64: W: invalid-license LGPL-2.1
userspace-rcu-devel.x86_64: W: invalid-license LGPL-2.1
userspace-rcu.src: W: invalid-license LGPL-2.1
userspace-rcu.x86_64: W: invalid-license LGPL-2.1
    => see above
userspace-rcu-devel.x86_64: W: no-documentation
    => can be ignored
userspace-rcu.x86_64: W: shared-lib-calls-exit /usr/lib64/liburcu-qsbr.so.0.0.0
exit at GLIBC_2.2.5
userspace-rcu.x86_64: W: shared-lib-calls-exit
/usr/lib64/liburcu-defer.so.0.0.0 exit at GLIBC_2.2.5
userspace-rcu.x86_64: W: shared-lib-calls-exit /usr/lib64/liburcu-mb.so.0.0.0
exit at GLIBC_2.2.5
userspace-rcu.x86_64: W: shared-lib-calls-exit /usr/lib64/liburcu.so.0.0.0
exit at GLIBC_2.2.5
userspace-rcu.x86_64: W: shared-lib-calls-exit /usr/lib64/liburcu-bp.so.0.0.0
exit at GLIBC_2.2.5
    => should be discussed with upstream, run rpmlint -i on the binary rpm for
reasons of this warning

- a test suite is included in the source archive, but it's not run. If possible
the test suite should be run in the %check section

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.