[Bug 526651] Review Request: xpaint - An X Window System image editing or paint program

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 22 14:44:33 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526651


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org




--- Comment #18 from Thomas Spura <tomspur at fedoraproject.org>  2009-10-22 10:44:31 EDT ---
Just a few comments (I'm no sponsor anyway ;)):

rpmlint output is not clean.

- Take a look to
https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath for the
error with rpath
- use %configure instead just ./configure

- Doesn't the folder /usr/share/xpaint/include/ belongs to /usr/include/xpaint?
  At least this folder should go into a -devel subpackage.
  What about the c_scripts folder? It it needed at runtime?



- There is a new version upstream (again^^).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list