[Bug 530204] Review Request: rubygem-hawler - Hawler, the Ruby HTTP crawler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530204





--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-24 23:44:49 EDT ---
Well, I have not checked your latest srpm yet, however:
(In reply to comment #1)
> * License
>   - MIT.

No, this is BSD, not MIT, sorry...

(In reply to comment #2)
> (In reply to comment #1)
> > * Test
> >   - As this gem file contains test/ directory, please
> >     add %check section and execute some tests there.  
> 
> Two out of three tests require rubygem-hpricot, which is not in Fedora yet.
> Enabled the other test though.

- rubygem-hpricot is already in Fedora and actually the maintainer
  is me (if upgrade or bug fix is needed, please file a bug)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.