[Bug 520491] Review Request: maven-embedder - Maven Embedder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520491


Milos Jakubicek <xjakub at fi.muni.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Milos Jakubicek <xjakub at fi.muni.cz>  2009-09-01 06:03:29 EDT ---
OK, here are just a few issues:

- remove BR: maven2-plugin-surefire (obsoleted by maven2)
- is there any reason to use the Epoch: 0 tag? If not please remove it.
- the creation of local maven repository could go into the with_maven
conditional

Otherwise the package is sane:
+ follows general guidelines (proper licensing, builds from source, proper
instructions for getting source, ...)
+ follows Java guidelines (builds with maven in offline repo, installs into
proper maven locations, docs are in -javadoc, ...)
+ builds in current rawhide: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=1647555

Provided the BR & Epoch mentioned above will be fixed when importing, this
package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.