[Bug 517763] Review Request: voms - Virtual Organization Membership Service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517763





--- Comment #6 from Steve Traylen <steve.traylen at cern.ch>  2009-09-01 15:12:38 EDT ---
The init.d script.
Largely inspired by:
https://fedoraproject.org/wiki/Packaging:SysVInitScript
again , this is all really upstream stuff.

1) Running start on running service should be a success.
# /etc/init.d/voms start
Starting voms(other): VOMS (2790) is already running
                                                           [FAILED]
Starting voms(test): VOMS (2806) is already running
                                                           [FAILED]
2) Running stop on stopped service should be success.
# /etc/init.d/voms stop
Stopping voms(other):                                                          
[FAILED]
Stopping voms(test): 
                                                           [FAILED]

3) Generally there is a lot of white space and new lines between
   message and the [OK] or [FAIL]

4) If I start and then kill the daemons.
# /etc/init.d/voms start
Starting voms(other): 
                                                           [  OK  ]
Starting voms(test): 
                                                           [  OK  ]
it returns status okay.

As for what should happen when one of the configured process is not
running I guess that if any one is not running then status should
return not running.

5) Adding some basic sanity checks makes sense. e.g
[ ! -r $X509_USER_KEY ]  && echo -n "$prog: No hostkey file"  && failure &&
echo && exit 5
[ ! -r $X509_USER_CERT ] && echo -n "$prog: No hostcert file" && failure &&
echo && exit 5

same if /etc/voms is empty.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.