[Bug 520719] New Package for Dogtag PKI: tomcatjss

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520719





--- Comment #3 from Dennis Gilmore <dennis at ausil.us>  2009-09-01 19:50:38 EDT ---
rpm link gives some warnings

rpmlint /var/lib/mock/fedora-rawhide-x86_64/result
tomcatjss.src: W: strange-permission tomcatjss.spec 0600
tomcatjss.noarch: W: spurious-executable-perm
/usr/share/doc/tomcatjss-1.2.0/README
tomcatjss.noarch: W: spurious-executable-perm
/usr/share/doc/tomcatjss-1.2.0/LICENSE

we should make sure the docs are not executable
source is not available for download at the url in the spec

fedora 8 has not been supported for some time now 
# Override the default 'pki_jdk' and 'pki_jre' on Fedora 8 platforms
%{?fc8:%define pki_jdk    java-devel >= 1.7.0}
%{?fc8:%define pki_jre    java >= 1.7.0}
should be removed along with the pki_jdk and pki_jre macros 

/var/lib/tomcat5/server/lib/tomcatjss.jar in %files should be 
%{_sharedstatedir}/tomcat5/server/lib/tomcatjss.jar

mkdir -p %{buildroot}/var/lib/tomcat5/server/lib
cd %{buildroot}/var/lib/tomcat5/server/lib

should be 
mkdir -p %{buildroot}%{_sharedstatedir}/tomcat5/server/lib
cd %{buildroot}%{_sharedstatedir}/tomcat5/server/lib

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.