[Bug 520832] Review Request: quotatool - Disk utility for managing user quotas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520832


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de
             Blocks|                            |177841(FE-NEEDSPONSOR)




--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de>  2009-09-02 13:40:27 EDT ---
This seems to be your first package submission to Fedora. Thus, you need a
sponsor reviewing this package (see
http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_Sponsored)

I'm not a sponsor, so consider the following comments as informal. 
There are some issues in the spec file that should be fixed:

- According to the source files GPLv2 is OK. However, the project homepage
doesn't mention a GPL version number but links to GPLv3. Maybe you should ask
upstream to fix this ambiguity

- add a short comment above %Patch0 about what the patch does

- I'd suggest to use the description text from the project website because it's
a bit more detailed.

- remove -n quotatool-%{version} from %setup, as it's not necessary

- Patch0 is not applied because of the wrong parameter -p1 (remove -p1 from
%patch0)

- remove INSTALL from %doc (it's not of much use in a binary package)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.