[Bug 521240] Review Request: maven-plugin-bundle - Maven Bundle Plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521240





--- Comment #1 from Andrew Overholt <overholt at redhat.com>  2009-09-04 14:50:04 EDT ---
X won't build (needs additional BRs -- see
http://overholt.fedorapeople.org/maven-plugin-bundle.spec)
X probably needs Requires fixed up to match or be similar to BRs
X the last sentence of the description should be removed.
X files good except for %{_javadir} line ... %{_javadir}/*, perhaps?

- sources ok (md5sums match)
- licensing fine
- naming fine
- lines <= 80 where possible
- macros good, clean used appropriately
- rpmlint fine:

$ rpmlint
/home/overholt/rpmbuild/SRPMS/maven-plugin-bundle-2.0.0-1.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint
/home/overholt/rpmbuild/RPMS/noarch/maven-plugin-bundle-2.0.0-1.fc11.noarch.rpm
maven-plugin-bundle.noarch: W: no-documentation
maven-plugin-bundle.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-plugin-bundle
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint
/home/overholt/rpmbuild/RPMS/noarch/maven-plugin-bundle-javadoc-2.0.0-1.fc11.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.