[Bug 517859] Review Request: vmpsd - vmpsd is a GPL implementation of Cisco Systems' VMPS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517859





--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-09-05 13:42:07 EDT ---
For -4:

* SourceURL
  - I recommend to use %{name} and %{version} macro in
    SourceURL (especially %{version}), with this you probably
    won't have to change SourceURL when version is upgraded:
    https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* condrestart
  - condrestart should be in %postun:
   
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets

* Timestamps
  - Please add "-p" option to "install" command
    https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
------------------------------------------------------
install %{S:2} $RPM_BUILD_ROOT%{_initrddir}/%{name}
------------------------------------------------------

* Macros
  - /usr/share/man should be %{_mandir}

* Documents
  - Forgot to mention, however:
  * Please add COPYING{.GPL} to %doc
  * And consider to add ChangeLog, README to %doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.