[Bug 518017] Review Request: php-pecl-sphinx - PECL extension for Sphinx SQL full-text search engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518017


Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review?




--- Comment #1 from Remi Collet <fedora at famillecollet.com>  2009-09-06 01:47:46 EDT ---
All seems ok in the spec.

Just a quick note

Froms upstream, it requires PHP 5.1.3 (which is still not available in EPEL4),
so, for documentation:
BuildRequires: php-devel >= 5.1.3

A minimal %check seems usefull (even if not mandatory), for example :

%check
# simple module load test
cd %{pecl_name}-%{version}
php --no-php-ini \
    --define extension_dir=modules \
    --define extension=%{pecl_name}.so \
    --modules | grep %{pecl_name}

I will do a full review asap.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.