[Bug 521182] Review Request: perl-CatalystX-Component-Traits - Automatic Trait Loading and Resolution for

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521182


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Parag AN(पराग) <panemade at gmail.com>  2009-09-07 03:06:46 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1654079
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d1c624fb4ea79869a78382ec1db95860b696d8bc 
CatalystX-Component-Traits-0.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=7, Tests=19,  3 wallclock secs ( 0.03 usr  0.01 sys +  3.28 cusr  0.20
csys =  3.52 CPU)
+ Package perl-CatalystX-Component-Traits-0.10-1.fc12.noarch =>
Provides: perl(CatalystX::Component::Traits) = 0.10
Requires: perl(Carp) perl(List::MoreUtils) perl(Moose::Role)
perl(namespace::autoclean) perl(Scalar::Util) rpmlib(VersionedDependencies) <=
3.0.3-1
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.