[Bug 517763] Review Request: voms - Virtual Organization Membership Service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517763





--- Comment #10 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-09-07 06:54:33 EDT ---
(In reply to comment #9)
> So to wrap up two things:
> 
> 1) On upgrade something odd happens.
> 
> rpm -Uvh voms-*
>     1:voms                   warning: /etc/vomses created as /etc/vomses.rpmnew
> 
> and results in 
> 
> $ ls -ld /etc/vomses /etc/vomses.rpmnew 
> drwxr-xr-x. 2 root root 4096 2009-08-31 10:44 /etc/vomses
> -rw-r--r--. 1 root root    0 2009-09-04 15:35 /etc/vomses.rpmnew
> 
> which is just odd.

Version -2 of the package did not contain the /etc/vomses file, this file was
added in version -3. You had already created /etc/vomses when testing the -2
version, and since /etc/vomses is tagged as a config file that should not be
overwritten the new version form the package was created as /etc/vomses.rpmnew.
This is exactly as it should be and is neither odd nor strange.

> I would guess adding a %dir sorts this out but am unsure.
> %config(noreplace) %{_sysconfdir}/vomses

/etc/vomses is a file and not a directory, so tagging it as %dir is not
appropriate.

> 2) I think /usr/share/m4 containing /usr/share/m4/voms.mp4 is created by but
> not 
>    owned by the %file listing.

Yet another "let's install files in weird places" issue from upstream. I have
moved the file to the right place (usr/share/aclocal - where all other .m4
files are). I added a dependency on automake to the -devel package to depend on
a package that owns this directory. Thank you for pointing this one out.

> 3) Lastly
>    koji build --scratch dist-f12 voms-.....src.rpm
> 
>  http://koji.fedoraproject.org/koji/taskinfo?taskID=1654893
> 
>    clearly has some build problems.

Yes, the package needed porting to openssl 1.0. Porting has been done and the
patch sent upstream.

Koji scratch build is now OK:

https://koji.fedoraproject.org/koji/taskinfo?taskID=1659459

> Steve  

New version is here:

Spec URL: http://www.grid.tsl.uu.se/review/voms.spec
SRPM URL: http://www.grid.tsl.uu.se/review/voms-1.9.11-4.fc11.src.rpm

    Mattias

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.