[Bug 518647] Review Request: django-robots - django extension to manage correctly robots.txt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518647


Ionuț Arțăriși <mapleoin at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mapleoin at fedoraproject.org




--- Comment #2 from Ionuț Arțăriși <mapleoin at fedoraproject.org>  2009-09-08 11:44:57 EDT ---
Hello!

I am not in the packager group and therefore I will not be able to APPROVE
your package. I am only reviewing, trying to help.

Here are my suggestions (I've annotated this diff
http://mapleoin.fedorapeople.org/pkgs/robots.diff):


--- django-robots.spec.orig 2009-08-25 23:41:41.000000000 +0300
+++ django-robots.spec 2009-09-08 18:33:51.713661335 +0300
@@ -1,5 +1,7 @@


I can see that getting the source isn't trivial, but bitbucket provides
archives of snapshots.

%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}

+%define snapshot 9db16b76dc19
+
 Name:           django-robots
 Version:        0.6.1
 Release:        1%{?dist}
@@ -8,11 +10,12 @@
 Group:          Development/Languages
 License:        BSD
 URL:            http://bitbucket.org/jezdez/django-robots/
-Source0:        %{name}-%{version}.tar.gz
+Source0:        http://bitbucket.org/jezdez/%{name}/get/%{snapshot}.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

The package wouldn't build in mock without setuptools:

 BuildArch:      noarch
 BuildRequires:  python-devel
+BuildRequires:  python-setuptools-devel
 Requires:       Django

 %description
@@ -20,7 +23,7 @@
 robots exclusion protocol, complementing the Django Sitemap contrib app.

 %prep
-%setup -q -n %{name}-%{version}
+%setup -q -n %{name}

 %build
 %{__python} setup.py build

Finally, I think the %files section would be better like this:

@@ -35,10 +38,9 @@

 %files
 %defattr(-,root,root,-)
-%doc README.rst
-%doc INSTALL.txt
-%doc docs/overview.txt
-%{python_sitelib}/*
+%doc README.rst INSTALL.txt docs/*
+%{python_sitelib}/robots/*
+%{python_sitelib}/django_robots-%{version}-py2.6.egg-info

 %changelog
 * Fri Aug 21 2009 Luca Botti <lucabotti at fedoraproject.org>

I also found the following rpmlint errors which should be easy to fix:

django-robots.noarch: W: no-version-in-last-changelog
django-robots.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/robots/locale/de/LC_MESSAGES/django.mo
django-robots.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/robots/locale/fr/LC_MESSAGES/django.mo
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Good luck!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.