[Bug 507223] Review Request: dalston - Moblin System Information Icons

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507223


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(rc040203 at freenet.
                   |                            |de)




--- Comment #27 from Christoph Wickert <cwickert at fedoraproject.org>  2009-09-10 12:47:28 EDT ---
Let's see what we've got:

$ rpmlint Downloads/dalston-*
dalston.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/dalston-power-applet.desktop
dalston.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/dalston-volume-applet.desktop
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

Minor. Please mark the files %config (although it's not really necessary since
changes will be saved in user's XDG_CONFIG_HOME.)

OK - Source matches upstream source by md5 aeb4b0c644694a9833c92e1976fab6c6
OK - SourceURL valid
OK - License tag correct: LGPLv2 and GPLv2+
OK - dropped redundant glib2-devel BR
OK - dropped Requires(post): /bin/touch
OK - %description ends with dot
OK - timestamps preserved during %install
OK - no libtool archives, so nothing to remove
OK - README added to %doc
OK - verbose make rules
OK - configure is only run once


Issues:
FIX - SHOULD: Scriptlets not sane: you are still updating icon cache although
there are no icons.
- autotools incompatibility from comment #15. Bug in gnome-autogen.sh
- Makefile.am problem from comment #15: harmless


(In reply to comment #23)
> Mr. Robinson refuses to use this tarball
> in compliance to the autotools' working principles.
> 
> Or differently: If Mr. Robinson was using a "make dist" generated tarball or
> was running the autotools in advance to building and was applying patches, all
> the issues we currently are discussing would not be around.  

No hypothetical "what - if" please. There are no "make dist" generated tarballs
and you said Peter uses *this one* incorrectly. Ether you come up with a patch
or I'm going to approve this package regardless of the running autotools. IMO
this is a minor issue here, so I'm not going to delay this review for it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.