[Bug 522726] Review Request: maven-plugin-build-helper - Build Helper Maven Plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522726





--- Comment #2 from Alexander Kurtakov <akurtako at redhat.com>  2009-09-11 11:38:11 EDT ---
(In reply to comment #1)
> X one file is under ASL 2.0 (everything else is MIT) so please update License
> to reflect
Fixed.
> X please use your full name and email address in %changelog :)
Fixed :)
> X please add Requires(post) and postun on jpackage-utils
Fixed.
> 
> - source matches upstream
> - macros good
> - builds fine
> - versioning good
> - %files fine
> - rpmlint fine:
> 
> $ rpmlint
> /home/overholt/rpmbuild/SRPMS/maven-plugin-build-helper-1.4-1.fc11.src.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> $ rpmlint
> /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-build-helper-1.4-1.fc11.noarch.rpm
> maven-plugin-build-helper.noarch: W: no-documentation
> maven-plugin-build-helper.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/maven-plugin-build-helper
> 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> $ rpmlint
> /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-build-helper-javadoc-1.4-1.fc11.noarch.rpm
> -standard-dir-perm /usr/share/javadoc/maven-plugin-build-helper-1.4/org 0775
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.  

New sources:
Spec URL: http://akurtakov.fedorapeople.org/maven-plugin-build-helper.spec
SRPM URL:
http://akurtakov.fedorapeople.org/maven-plugin-build-helper-1.4-1.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.