[Bug 478372] Review request: Mathgl - Scientific plotting library.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478372





--- Comment #37 from D Haley <mycae at yahoo.com>  2009-09-12 01:00:26 EDT ---
SPEC URL: http://dhd.selfip.com/427e/mathgl-1.9-5.spec
SRPM URL: http://dhd.selfip.com/427e/mathgl-1.9-5.fc10.src.rpm 

Koji Builds:
F10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1672567
F11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1672572

rpmlint output:
$ rpmlint `cat tmp | awk '{print $2}'`
catmathgl.i386: W: shared-lib-calls-exit /usr/lib/libmgl-glut.so.5.0.0
exit at GLIBC_2.0
 mathgl-devel.i386: W: no-documentation
tmp
5 packages and 0 specfiles checked; 0 errors, 2 warnings.
[makerpm at spiderbox SPECS]$ cat tmp
Wrote: /home/makerpm/rpmbuild/SRPMS/mathgl-1.9-5.fc10.src.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/i386/mathgl-1.9-5.fc10.i386.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/i386/mathgl-devel-1.9-5.fc10.i386.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/noarch/mathgl-doc-1.9-5.fc10.noarch.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/i386/mathgl-debuginfo-1.9-5.fc10.i386.rpm


>- Please move the buildroot tag somewhere else from the middle of
>BuildRequires. I prefer the order: BuildRoot, BuildRequires, Requires.
Done.

>- Devel package does not contain static libraries, remove them from the
> summary.
Done.

>- The package needs to own
> %{_datadir}/%{name}/
>instead of just
> %{_datadir}/%{name}/fonts/*.vfm
Done

>- Add COPYING, COPYRIGHT, NEWS, TODO.
COPYRIGHT NEWS and TODO have been included. COPYING is not included as this is
a GPLv3 licence, and conflicts with the source headers.

>- License is GPLv2+ not GPLv3.
I emailed upstream again, asking for clarification (fix headers or remove GPL3
licence). I still believe that GPL3 was the better option, given the presence
of the COPYING file (gplv3 is compatible with gpl2, but not vice versa).
Regardless, this has been to changed GPLv2+, as requested.

I am aware of the wiki page that describes how to select the GPL version,
however it doesn't cover this type of internal inconsistency.

Diff:
--- mathgl-1.9-4.spec 2009-08-15 18:23:08.000000000 +1000
+++ mathgl.spec 2009-09-12 14:38:14.000000000 +1000
@@ -1,10 +1,10 @@
 %{!?octave_api:%global octave_api %(octave-config -p API_VERSION || echo 0)}
 Name: mathgl
 Version: 1.9
-Release: 4%{?dist}
+Release: 5%{?dist}
 Summary: Cross-platform library for making high-quality scientific graphics
 Summary(ru): MathGL - это библиотека для осуществления высококачественной
визуализации данных
-License: GPLv3
+License: GPLv2+
 Group: Development/Libraries
 Url: http://mathgl.sourceforge.net
 Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tgz
@@ -18,10 +18,7 @@
 #Remove empty libmgl-wx from compilation
 Patch3: %{name}-no-mglwx.patch

-Requires(post): info
-Requires(preun): info
-
-Requires: octave(api) = %{octave_api}
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 # mandatory packages
 BuildRequires: gsl-devel libpng-devel libtool-ltdl-devel libtool 
@@ -30,13 +27,17 @@
 # optional packages
 BuildRequires: freeglut-devel hdf5-devel libjpeg-devel libtiff-devel
fltk-devel qt4-devel
 BuildRequires: wxGTK-devel giflib-devel octave-devel
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 #For autoreconf (required for patch1, libtool)
 BuildRequires: autoconf
 BuildRequires: automake
 BuildRequires: libtool

+Requires(post): info
+Requires(preun): info
+
+Requires: octave(api) = %{octave_api}
+
 %description
 Mathgl is a cross-platform library for making high-quality scientific
 graphics. It provides fast data plotting and handling of large data
@@ -45,7 +46,7 @@
 opengl applications

 %package devel
-Summary: Static libraries and header files for %{name} library
+Summary: Libraries and header files for %{name} library
 Group: Development/Libraries
 Requires: %{name} = %{version}-%{release}

@@ -73,7 +74,7 @@
 %setup -q

 #convert EOL encodings, maintaining timestames
-for file in AUTHORS ChangeLog.txt README; do
+for file in AUTHORS ChangeLog.txt README COPYRIGHT; do
  sed 's/\r//' $file > $file.new && \
  touch -r $file $file.new && \
  mv $file.new $file
@@ -179,10 +180,10 @@

 %files
 %defattr(-,root,root,-)
-%doc AUTHORS ChangeLog.txt README
+%doc AUTHORS ChangeLog.txt README COPYING COPYRIGHT NEWS TODO
 %{_libdir}/*.so.*
 %{_bindir}/mgl*
-%{_datadir}/%{name}/fonts/*.vfm
+%{_datadir}/%{name}/
 %{_prefix}/libexec/octave/packages/%{name}-1.9.0/
 %{_datadir}/octave/packages/%{name}-1.9.0/
 %{_infodir}/%{name}.*.gz
@@ -198,6 +199,11 @@
 %doc texinfo/docs/*

 %changelog
+* Sat Sep 12 2009 <mycae(a!t)yahoo.com> 1.9-5
+- Removed the word "static" from devel description, as doesn't have static
+- Fonts now owned at datadir/name level
+- Added COPYRIGHT NEWS and TODO
+
 * Sat Aug 15 2009 <mycae(a!t)yahoo.com> 1.9-4
 - Fix octave installation method
 - Remove wx lib, which doesn't have meaningful code.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.