[Bug 503136] Review Request: csync - a file synchroniser utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503136





--- Comment #8 from Alex Hudson (Fedora Address) <fedora at alexhudson.com>  2009-09-12 08:51:09 EDT ---
Hi Jussi,

Apologies for the delay. The updated spec and SRPM are:

http://alexh.fedorapeople.org/reviews/csync/csync.spec
http://alexh.fedorapeople.org/reviews/csync/csync-0.43.0-3.fc11.src.rpm

The main thing which remains unaddressed is the use of the test suite. I've put
in place the code to run check, and on my local system this works fine.
However, when submitted to koji, it doesn't run. I assume there is something
about the test which fails on koji either in what it's trying to do, or its
assumptions about how the build works, but I haven't yet been able to work out
why. I will keep looking at this though!

Instead of the explicit dep on -libs, I've put COPYING in both packages - I
think it's nicer, and rpmlint doesn't like the explicit dep anyway. 

I've also checked that the config isn't used by the library, so I'm sure that's
in the right place.

The other problems you raised should now be addressed.

Many, many thanks again for your work!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.