[Bug 521430] Review Request: etckeeper - Store /etc in git, mercurial, bzr or darcs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521430


Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |terjeros at phys.ntnu.no
               Flag|                            |fedora-review?




--- Comment #6 from Terje Røsten <terjeros at phys.ntnu.no>  2009-09-13 15:32:48 EDT ---
 - rpmlint
etckeeper.src:76: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/%{name}.*
etckeeper.noarch: W: only-non-binary-in-usr-lib
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/post-install.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/init.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/update-ignore.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/uninit.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/commit.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/pre-install.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/pre-commit.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/unclean.d/README
3 packages and 0 specfiles checked; 1 errors, 9 warnings.

All these errors and warnings is harmless. ok.

- naming. ok.
- spec file name. ok.
- legible and American English. ok.
! license. GPL file has GPLv2, while debian/copyright has GPLv2+
  no files has license information, could you ping upstream about this?
- guidelines. ok. remove comments in spec file?
- source tarball:
  d41439dd78d1f85ad77aafdbeed4d460  etckeeper_0.40.tar.gz
  d41439dd78d1f85ad77aafdbeed4d460  etckeeper_0.40.tar.gz.1 ok.
- build and runs fine.
  koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1675401 ok.
! own all dirs.
  + add %dir /etc/etckeeper, it's not include.
  + add /etc/bash_completion.d too (a bit strange, seems to be normal though)
  + /usr/lib/yum-plugins and /etc/yum/pluginconf.d: this is possible yum dep,
    however I am tempted to relax that.
- defattr. ok.
- file listing. ok.
- clean, macros. ok.
- subpackage. ok.
- install, utf-8. ok.


Optional:

 etckeeper.8 has:

SEE ALSO
       /usr/share/doc/etckeeper/README.gz

could change that by sed/perl to %{_docdir}/%{name}-%{version}/README

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.