[Bug 520701] Review Request: seeker - Random access disk benchmark utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520701





--- Comment #2 from Ville Skyttä <ville.skytta at iki.fi>  2009-09-13 17:10:30 EDT ---
(In reply to comment #1)
> ?   Witold Baryluk's modification is the multithreaded version that is being
> packaged here. I think that explicitly stating that in the Description, and
> with the Source0: comment would be a good idea.

Added, even though it might be subject to bitrot.

> ?   Would it be worth having a script that enumerates connected disks, and
> performs the test on each one, pausing at completion ? And providing a
> desktop file as an easy way to run it ?

Perhaps, patches welcome ;).  Not rocket science but the script should take
root access requirement into account.  But I think this can wait until
post-review.  Since you were considering packaging it, I can happily hand it
over for you to maintain and improve, or co-maintain if you prefer that...

> ?   why is the binary being placed in /usr/sbin ?

I assume you mean compared to placing it in /usr/bin?  Because running it
requires root access and I don't want to clutter normal users' PATH with it in
setups that don't have /usr/sbin there.  With recent Fedora defaults, /usr/sbin
vs /usr/bin doesn't make much practical difference at all because both are in
default PATH and I think this tool fits better in the former anyway.

> ?   consider including in %doc the html saveas from the original web site,
> since it gives a decent background on usage.

Done as upstream gives CC BY-SA 2.5 permission to do that at
http://www.linuxinsight.com/about.html

New srpm at http://scop.fedorapeople.org/packages/seeker-3.0-2.fc11.src.rpm,
specfile URL unchanged.

* Sun Sep 13 2009 Ville Skyttä <ville.skytta at iki.fi> - 3.0-2
- Address review comments (#520701):
- Improve %description.
- Include upstream article in docs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.