[Bug 522988] Review Request: dyndns - A dynamic DNS client for the free service afraid.org

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522988





--- Comment #3 from Erick Calder <e at arix.com>  2009-09-14 15:13:29 EDT ---
> $ rpmlint dyndns-1.0-1.fc11.src.rpm 

ugh.  I should have run it :)

> - the license tag must be GPLv2+

fixed

> - add a proper BuildRoot tag

I actually had removed this tag because of the text below (found at the link
you indicate):

"The RPM in Fedora 10 defines a default buildroot so in Fedora 10 and above it
is no longer necessary to define a buildroot tag. Fedora releases older than 10
and EPEL releases older than or equal to 5 still need to have the tag."

but I guess I should support older versions, so I've added it back

> no-cleaning-of-buildroot %install can be ignored

added back

> - add your full name to the %changelog entry

done

[rpm at janus ~]$ rpmlint /var/ftp/rpmz/src/dyndns-1.0-1.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

:)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.