[Bug 522988] Review Request: dyndns - A dynamic DNS client for the free service afraid.org

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522988





--- Comment #5 from Martin Gieseking <martin.gieseking at uos.de>  2009-09-14 18:15:05 EDT ---
rpmlint is also unhappy with the binary package: :)

rpmlint /var/lib/mock/fedora-11-x86_64/result/*.rpm
dyndns.x86_64: E: no-binary
dyndns.x86_64: E: zero-length /var/cache/dyndns
dyndns-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 3 errors, 0 warnings.

Adding BuildArch: noarch will remove the first and third error. Concerning the
zero-length file I'm not sure. Is it really necessary to package the empty file
/var/cache/dyndns? 

Erick, you should also increase the release tag every time you make changes to
the spec file (so the current release is 2). 
Finally two minor notes: your email address given in the changelog seems to
lack at least the TLD. Also, the list items in each changeset should start with
a hyphen (even if there's only one entry), e.g:

* Sat Sep 12 2009 Erick Calder <rpm at janus.XYZ> - 1.0-1
- Initial build

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.