[Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486570


Toshio Ernie Kuratomi <a.badger at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |a.badger at gmail.com
         AssignedTo|nobody at fedoraproject.org    |a.badger at gmail.com




--- Comment #9 from Toshio Ernie Kuratomi <a.badger at gmail.com>  2009-09-15 02:50:54 EDT ---
Not quite a complete review.  I still have some rpmlint information to verify. 
But there's some stuff to fix or discuss so I might as well post what I have:

Good:                                                                           
* Builds in koji                                                                
* named according to the naming guidelines                                      
* licensed according to the GPLv3+ as specified in the spec file                
* license file included.                                                        
* spec file is legible                                                          
* source matches upstream                                                       
* No file listed twice                                                          
* Permissions set properly                                                      
* Cleans the buildroot                                                          
* Uses macros consistently                                                      
* Headers in -devel package                                                     
* No static libraries or libtool archives                                       
* Devel package Requires the base package                                       


NEEDSWORK:
* It looks like all the libauth* files in the %{_libdir}/%{name}/ directory
  are plugins, not shared libs.  No need to run ldconfig for the subpackages
  that just contain those types of shared objects.                          
* There's no libraries in %{_libdir}.  RPATH is being used to load the needed 
  libraries from %{_libdir}/%{name}/ (libcourierauth.so,                    
  libcourierauthcommon.so).  The Packaging Guidelines specify that this should
  be done with a file in %{_sysconfdir}/ld.so.conf.d/ instead:                
    http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath        

  I also wonder why we don't just put libcourier* directly into %{_libdir}?     
* Nothing owns %{_libdir}/%{name} or %{_libexecdir}/%{name} or                
  %{_sysconfdir}/authlib I suggest the base package does this.                

* rpmlint 
courier-authlib.i586: W: conffile-without-noreplace-flag
/etc/authlib/authdaemonrc.dist                                                  
courier-authlib-ldap.i586: W: conffile-without-noreplace-flag
/etc/authlib/authldaprc.dist
courier-authlib-mysql.i586: W: conffile-without-noreplace-flag
/etc/authlib/authmysqlrc.dist
courier-authlib-pgsql.i586: W: conffile-without-noreplace-flag
/etc/authlib/authpgsqlrc.dist

 - It looks like all of these *rc.dist files are just vanilla versions of the
   *rc config files.  Why do we distribute these at all?

[Some more rpmlint messages will be posted in a followup]

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.