[Bug 520550] Review Request: IVAN - SDL roguelike
bugzilla at redhat.com
bugzilla at redhat.com
Wed Sep 16 00:35:43 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=520550
--- Comment #6 from Ryan Rix <phrkonaleash at gmail.com> 2009-09-15 20:35:41 EDT ---
[[> Patch1: %{name}-%{version}-fedora.patch
Dubious. The C++ fixes and the Makefile patch could be split into two patches.
So when a compiler update required further fixes, you could simply
rediff/enhance the C++ specific patch. But why is a patch to config.log and
config.status included? Those are files created at build-time.
]]
I'm not entirely sure... I suppose I need to dist-clean before I generate the
patch, correct?
I've implemented both of your suggestions (thank you both very much!) and will
rebuild the rpm after I get the patch all ironed out.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list