[Bug 520460] Review Request: perl-POE-Component-Pluggable - A base class for creating plugin-enabled POE components

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520460


Chris Weyl <cweyl at alumni.drew.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(cweyl at alumni.drew |
                   |.edu)                       |




--- Comment #2 from Chris Weyl <cweyl at alumni.drew.edu>  2009-09-15 20:34:57 EDT ---
(In reply to comment #1)
> I used cpanspec (recommended by http://fedoraproject.org/wiki/Packaging:Perl)
> to verify I'd get something similar to your spec file. There were only two
> non-trivial differences:
>  - Your specfile has: %{?perl_default_filter} - I did not find it mentioned in
>    the guidelines, but I found some BZs explaining it and I believe it is
>    correct.

The %perl_default_filter is a relatively new innovation: by policy no package
is permitted to either provide from or require for anything under %_docdir, yet
RPM insists on doing just that....  %perl_default_filter prevents %_docdir dep
issues, as well as preventing any shared library provides from creeping in
(which doesn't do anything here, as this is a noarch package).

>  - My generated specfile has:  Requires: perl(Task::Weaken)
>    Perhaps you should add it? Or explain to me why it should not be there.

cpanspec adds as Requires deps that the metadata files (typically Makefile.PL)
included with the tarball say it should; however long standing convention is to
not use these explicit requires and allow the auto dep/prov scripts to take a
stab at it.

The scripts don't always do a great job (particularly w.r.t. versioned deps),
as the typical way to express dependencies is through included metadata files. 
I've been playing with different ways to manage these deps explicly, but as I'm
not ready to recommend changes to the guidelines yet... and as such I don't
have any explicit Requires in at the moment.

Sound good? :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.