[Bug 522933] Review Request: pyicq-t - ICQ Transport for Jabber Servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522933





--- Comment #12 from Stefan Schulze Frielinghaus <stefan at seekline.net>  2009-09-16 03:54:50 EDT ---
Spec URL: http://www.seekline.net/fedora/pyicq-t.spec
SRPM URL: http://www.seekline.net/fedora/pyicq-t-0.8.1.5-5.fc11.src.rpm

(In reply to comment #11)
> From the spec file diff:
> 
> -%{_datadir}/pyicq-t
> +%{_datadir}/pyicq-t/data
[...]
>  => Missing is: 
> drwxr-xr-x /usr/share/pyicq-t

Yeah this was the problem. Due to the change of "%defattr(-,root,root,-)" I
also changed the directories. The tip to have a look at "rpmls ... | grep ^d"
is really good. I checked everything again and should be fine now.

> -touch %{buildroot}/etc/pyicq-t/config.xml
> +cp config_example.xml %{buildroot}/etc/pyicq-t/config.xml
> 
> This doesn't achieve what you think it does (according to %changelog). The
> problem here is that the file is made a %ghost. This also means that somebody
> (a person or a program) must create it after package installation, or else it
> won't exist like normal files.

Quite right. I also removed the ghost entry to create a default config file.

> The new initscript no longer displays the service name:
> 
> $ sudo service pyicq-t status
>  (pid  47117) is running...
> 
> $ sudo service pyicq-t status
>  is stopped

Argl, changed this one too. Had a look at other init scripts how they handle
this and changed it accordingly. Actually only a "$prog" was missing.

One question left. In https://fedoraproject.org/wiki/Packaging:SysVInitScript
they show a init script template. The sha-bang points to "/bin/sh" but my init
script uses "/bin/bash". I guess this is no problem, because about 30 other
packages installed on my Fedora system are using bash too. Or should we prefer
/bin/sh? I know that /bin/sh is only a symlink to bash but maybe someday Fedora
will change this behaviour?

Yesterday and today I did quite a lot of tests. Installed/removed the package
etc. The default config file is now created fine. Also the status of the init
script works fine. I checked every allowed init script argument and they all
seem to work fine. Additionally I checked all files listed by rpmls. rpmlint
still shows only the warnings/errors which are OK and shown in comment #10.

Fifth release is out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.