[Bug 523789] Review Request: python-mwclient - Mwclient is a client to the MediaWiki API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523789


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name
  Status Whiteboard|                            |NotReady




--- Comment #2 from Till Maas <opensource at till.name>  2009-09-16 16:49:15 EDT ---
Instead of %define, %global should be used in the spec.

The upstream tarball seems to bundle python-simplejson, which you install in
%install. This is wrong. There is also a Requires: on python-simplejson, so
something is wrong. Also copying the c source of _speedups.so is just wrong.
Please remove the NotReady from the Whiteboard if these issues are resolved. If
you have any questions, please ask.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.