[Bug 485652] Review Request: navit - Car navigation system with routing engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485652


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




--- Comment #37 from Till Maas <opensource at till.name>  2009-09-17 05:25:17 EDT ---
The release needs to include some date, e.g. of the time you created the
snapshot or ideally of the time the revision was commited:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

You can add the revision after the svn string in the release, if you want:

0.2.20090917svn2431


The patch does not have an comment wrt the upstream status:
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

You should probably run desktop-file-validate:
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

The snippets to update the icon cache are missing:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

Btw. there is the string NotReady in the status whiteboard, which should be
removed once this package needs some reviewer action, ie if above issues are
fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.