[Bug 516906] Review Request: frePPLe - Free Production Planning Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516906





--- Comment #10 from Michel Alexandre Salim <michael.silvanus at gmail.com>  2009-09-17 16:00:00 EDT ---
(meant to copy-and-paste the Koji build URL, sorry)
Koji F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1687259

rpmlint warnings on the binaries:
frepple.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libfrepple.so.0.0.0 /lib64/libm.so.6
frepple.x86_64: E: non-executable-script
/usr/lib/python2.6/site-packages/freppledb/manage.py 0644 /usr/bin/env
frepple.x86_64: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/freppledb/locale/nl/LC_MESSAGES/django.mo
frepple.x86_64: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/freppledb/locale/nl/LC_MESSAGES/djangojs.mo
frepple.x86_64: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/freppledb/locale/zh_TW/LC_MESSAGES/django.mo
frepple.x86_64: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/freppledb/locale/zh_TW/LC_MESSAGES/djangojs.mo
1 packages and 0 specfiles checked; 1 errors, 5 warnings.

frepple-devel.x86_64: W: summary-ended-with-dot The libraries and header files
needed for frePPLe development.

frepple-doc.x86_64: W: summary-ended-with-dot Documentation subpackage for
frePPLe.



Changes look good so far. But.. the URL field should not be removed, really; it
points to the program's homepage and is visible to the user (try rpm -qi on the
produced RPM). Only Source1 needs to be removed as it's redundant and never
referred to.

Some tests still fail locally:

======================================================================
FAIL: callback
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./runtest.py", line 245, in runExecutable
    self.assertFalse("Difference in output")
AssertionError

======================================================================
FAIL: name
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./runtest.py", line 245, in runExecutable
    self.assertFalse("Difference in output")
AssertionError

======================================================================
FAIL: problems
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./runtest.py", line 245, in runExecutable
    self.assertFalse("Difference in output")
AssertionError

----------------------------------------------------------------------
Ran 37 tests in 50.983s

FAILED (failures=3)
make[1]: *** [check] Error 1

Any idea why they pass on the build server? Might it be that they terminate
with no error if there is no Internet connection, but fail if there actually
is?

If you're planning to support only Fedora (and not EPEL, Extra Packages for
Enterprise Linux) then you can make the documentation subpackage noarch:

%package doc
...
BuildArch: noarch

to be safe, though, in case some EPEL maintainers want to bundle this at some
point in the future, you can %if-guard it as such:

# noarch subpackages require RPM >= 4.6.0, available in F-10 or later
# (and the upcoming RHEL 6). All Fedora versions are fine since the lowest
# supported version is 10

%if 0%{?fedora} || 0%{?rhel} > 5
BuildArch: noarch
%endif

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.