[Bug 522935] Review Request: mod_gnutls - GnuTLS module for the Apache HTTP server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522935


Tomas Mraz <tmraz at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #9 from Tomas Mraz <tmraz at redhat.com>  2009-09-17 17:31:57 EDT ---
I am not sure that I like the %{ooo} define too much - also the current package
guidelines state that %global should be used instead of %define. But I wouldn't
substitute this part of the URLs by a macro at all.

That is a minor issue you can fix before commit.

rpmlint output:
rpmlint -v ../SRPMS/mod_gnutls-0.5.5-4.fc11.src.rpm
../RPMS/x86_64/mod_gnutls-0.5.5-4.fc11.x86_64.rpm
../RPMS/x86_64/mod_gnutls-debuginfo-0.5.5-4.fc11.x86_64.rpm
mod_gnutls.src: I: checking
mod_gnutls.x86_64: I: checking
mod_gnutls.x86_64: E: non-standard-dir-perm /var/cache/mod_gnutls 0700
mod_gnutls-debuginfo.x86_64: I: checking
3 packages and 0 specfiles checked; 1 errors, 0 warnings.

The non-standard-dir-perm error is not a problem as this permission is right.

The package is APPROVED.

I will sponsor you for Fedora packaging when you create an account in the
Fedora Account System.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.