[Bug 520343] Review Request: clc - command line client for MUDs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520343


Jan Klepek <jan.klepek at hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(sean at middleditch.
                   |                            |us)




--- Comment #3 from Jan Klepek <jan.klepek at hp.com>  2009-09-18 09:12:23 EDT ---
1]
i didn't see there usage of fedora compiler flags.
https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

2] 
md5sum of download from SOURCE is different from tar which is in src.rpm
b6043dececbaa61e8a3b26a2bda33d38  clc-0.01.tar.gz
ed6d17913a6f8e1d9db4a210f5edef34  SOURCES/clc-0.01.tar.gz

3] macros usage
use only one style of macros or variable. not both in one spec file. so you
eiter replace variables with corresponding macros or macros with variables.
http://fedoraproject.org/wiki/Packaging/Guidelines#macros


otherwise it looks good
spec file is in english and have correct name
directories, files and ownership is correct
compiling/building ok
dependencies ok
clean section present

please fix 1],2],3].

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.