[Bug 522210] New Package for Dogtag PKI: pki-ca

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522210


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #8 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-09-18 09:26:58 EDT ---
Ugh. The spec file is a mess, too much definitions, too much commented bits and
so on.

- Is the license statement really necessary? After all,
http://fedoraproject.org/wiki/Licensing#License_of_Fedora_SPEC_Files

- You have defined %defattr(-,root,root), so there's no need to define
 %attr(-,root,root) 
for every single object in %files.

- The comment
 ## Without Requires something, rpmbuild will abort!
is nonsense. Rpmbuild will abort if you have an empty Requires: line, but if
you don't have any requirements, the package builds fine.

- You should drop 
## Without AutoReqProv: no, rpmbuild finds all sorts of crazy
## dependencies that we don't care about, and refuses to install
AutoReqProv:    no

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.