[Bug 524119] Review Request: nmon - Nigel's performance MONitor for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524119





--- Comment #3 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2009-09-18 09:42:21 EDT ---
(In reply to comment #1)
> - Drop the patch and the hard link, they are not necessary. Instead, just
> compile the program manually in %build (the makefile is trivial and badly
> written) with
>  gcc $RPM_OPT_FLAGS -D JFS -D GETUSER -D LARGEMEM -o nmon lmon%{version}.c
> 
> - In %install, just run
>  rm -rf $RPM_BUILD_ROOT
>  install -D -p -m 755 nmon $RPM_BUILD_ROOT%{_bindir}/nmon  

I believe it is better to fix the build system and send the fixes upstream.
That way other distributions won't have to invent their own workarounds. And
since this software is really simple to build, it shouldn't be too difficult to
fix the default build target and add an install target to the Makefile.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.