[Bug 520621] Review Request: laptop-mode-tools - Scripts to spin down hard drive and save power

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520621





--- Comment #2 from Ritesh Raj Sarraf <rsarraf at netapp.com>  2009-09-18 14:22:18 EDT ---
(In reply to comment #1)
> The spec needs a lot of fixing, therefore I added NotReady to the status
> whiteboard. Please remove it after you have addressed these issues:
> 
> 1) The spec does not match the srpm, the spec is for version 1.51, but the srpm
> is for version 1.50

Hmmm!! I'm not sure. I think I linked the r1.50 file.

> 2) GPL is not a valid license tag, it might be GPL+, GPLv2, GPLv2+, ...
> You can find more information about this here:
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#GPL_and_LGPL

Done

> 3) Vendor and Packager should not be used:
> https://fedoraproject.org/wiki/Packaging/Guidelines#Tags

I used it because the .spec file you reviewed is something I'm going to be
shipping with the upstream tarball. One of my goals with that spec is to make
it RPM distro generic.

> 4) The Distribution tag should probably not be used, but I asked on
> fedora-packaging about this
Same as 3

> 5) The init script should not be started automatically in %post imho, because
> the user might first want to tweak laptop-mode before it is started
It shouldn't harm. The default settings of laptop-mode-tools thrive to give you
a basic power saving profile.
If it is a policy, I can disable it.

> 6) %{_usr}/lib/pm-utils/sleep.d must not be owned by laptop-mode-tools, it is
> owned by filesystem for Fedora Rawhide (F12)

Hmmm!!! I'm not sure how to handle this. We ship a hook there.

> 7) The manpages in %files should hava an asterisk appended (*), because in the
> Fedora buildsystem, the manpages will be gzipped, so the pattern won't match.

Done

> Also it is not needed to mark them as %doc, this is already done automatically
What should be put as the default.

> 8) %{_usr}/sbin should be %{_sbindir} and %{_usr}/share %{_datadir}, also it is
> uncommon to use %{_usr} but to use %{_prefix} instead
> 
Done.  What about /usr/lib ?

> You also need to block FE-NEEDSPONSOR, because you do not have submitted any
> package to Fedora. Here is more information about the whole process:
> https://fedoraproject.org/wiki/Package_Review_Process  
Going through it.

Thank you for reviewing.

I am attaching a separate .spec because the spec I ship with the tarball needs
to be generic.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.