[Bug 524147] Review Request: libnetdevname -Development environment for libnetdevname

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524147





--- Comment #4 from Bill Nottingham <notting at redhat.com>  2009-09-18 14:39:13 EDT ---
This is not a package review. This is more of a code review.

I'm not really a fan of the API:

extern int netdev_pathname_to_name (char *);

This modifies the data you pass to it, which is ugly. Something like:

extern int netdev_pathname_to_name (const char *name, char **ret);

would be better. (Or, just directly return the name, and NULL on failure,
setting errno appropriately.)

In the absence of kernel support, all /dev/net names throw errors. Passing it
the existing /dev/net/tun also errors.

It only checks for /dev/net as a prefix. You pass it /dev/foo, or " bar", or
other invalid device names... it returns them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.