[Bug 521569] Review Request: perl-Locale-Maketext-Gettext - Joins the gettext and Maketext frameworks

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521569


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tibbs at math.uh.edu
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #2 from Jason Tibbitts <tibbs at math.uh.edu>  2009-09-18 15:04:07 EDT ---
Builds fine and rpmlint is silent.  The spec, being cpanspec generated, is nice
and clean.

I note that 1.28 is out, released well before you posted this review request. 
I checked the upstream changelog and it doesn't seem that there are any
functional changes, so I'll go ahead and review the current version.  However,
beware that if you do update, there may be some dependency issues because
packages reqired for the test suite are no longer listed in Build.PL.

I note that the test suite skips one test:
  t/99-pod.t ........... skipped: Test::Pod 1.00 required for testing POD
Generally this is a maintainer test anyway and its value to us is somewhat
minimal, but I would suggest that you add a build dependency on perl(Test::Pod)
anyway, because you'll at least be alerted of any issues with the
documentation.  The package still builds fine if you do this.

If you fix that one minor issue, I'll approve this package and sponsor you.

* source files match upstream.  sha256sum:
   3834e317e49e7bee4133f82d41cbc43e8eda92c6cdcde6c282021c083e0dc8f0  
   Locale-Maketext-Gettext-1.27.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Locale::Maketext::Gettext) = 1.27
   perl(Locale::Maketext::Gettext::Functions) = 0.13
   perl(Locale::Maketext::Gettext::Functions::_EMPTY) = 0.01
   perl(Locale::Maketext::Gettext::Functions::_EMPTY::i_default) = 0.01
   perl-Locale-Maketext-Gettext = 1.27-1.fc12
  =
   /usr/bin/perl
   perl >= 0:5.008
   perl(:MODULE_COMPAT_5.10.0)
   perl(Encode)
   perl(File::Spec::Functions)
   perl(Getopt::Long)
   perl(Locale::Maketext::Gettext)
   perl(Locale::Maketext::Gettext::Functions)
   perl(base)
   perl(strict)
   perl(vars)
   perl(warnings)

? %check is present and all tests pass:
   All tests successful.
   Files=13, Tests=350,  2 wallclock secs ( 0.10 usr  0.02 sys +  0.93 cusr  
    0.26 csys =  1.31 CPU)
  However, one test is skipped due to a missing build dependency.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.