[Bug 516906] Review Request: frePPLe - Free Production Planning Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516906





--- Comment #14 from Johan De Taeye <jdetaeye at users.sourceforge.net>  2009-09-19 02:44:57 EDT ---

The difference between you local machine and the build machine is that you have
the CherryPy package installed.

Comparing the test.out files with the .expect files, one can verify the
difference is coming from the following deprecation warnings generated by
CherryPy. The deprecation warnings don't affect the functioning of frePPLe at
all.
>>/usr/lib64/python2.6/site-packages/cherrypy/lib/cptools.py:4: >>DeprecationWarning: the md5 module is deprecated; use hashlib instead
>>  import md5
>>/usr/lib64/python2.6/site-packages/cherrypy/lib/sessions.py:16: >>DeprecationWarning: the sha module is deprecated; use the hashlib module instead
>>  import sha
>>/usr/lib64/python2.6/site-packages/cherrypy/_cperror.py:190: >>DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
>>  self.message = message

frePPLe uses CherryPy to implement an optional REST web service in Python code.
I didn't list CherryPy as a dependency in the spec file. Should it be added?
Since the web service will be used only by a limited subset of frePPLe users, I
give an error message when a user tries to use the web service module for the
first time. See the code in the file init.py:
>>try:
>>  import cherrypy
>>except:
>>  # Alternative definitions when cherrypy is not available.
>>  # We only want to report the missing module when the REST web service is 
>>  # really used.
>>  def RESTwebservice(address=None, port=8080):
>>    raise ImportError, "no module named cherrypy"    
>>else:  
>>  def RESTwebservice(address=None, port=8080):
>>  ... implementation of the web service ...  

Conclusion: The test failures can be ignored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.