[Bug 509310] Review Request: gpointing-device-settings - Configuration tool for pointing devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509310





--- Comment #14 from Gianluca Sforna <giallu at gmail.com>  2009-09-19 19:28:41 EDT ---
Spec URL: 
http://giallu.fedorapeople.org/gpointing-device-settings.spec
SRPM URL: 
http://giallu.fedorapeople.org/gpointing-device-settings-1.3.1-3.fc11.src.rpm


(In reply to comment #11)
> IMHO having just two packages:
> gpointing-device-settings
> and 
> gpointing-device-settings-devel
> would be better.

DONE

> * pkgconfig file: TODO
> - The pkgconfig file contains the following linker flags:
> Libs: -L${libdir} -lgpointing-device-settings
> which won't work at all, since the library's name is "libgpds.so". Please
> substitute the line with something like this:
> Libs: -L${libdir} -lgpds
DONE

> 
> * GUI applications must provide *.desktop file: TODO
> I'm quite sure that the gpointing-device-settings is the regular configuration
> dialog for the user to setup his mouse/touchpad preferences. Similar as it was
> done in the gsynaptics package it must be available in the Preferences menu:
> e.g. in System -> Preferences -> Pointing Device Settings
> Please add the according .desktop file.

DONE (.desktop file adapted from gsynaptic)

> 
> * Obsoletes: TODO
> - Obsoletes: the version must be greater than the version of the current
> package, otherwise the current gsynaptics pacakge would not be obsoleted
> Obsoletes: gsynaptics < 0.9.16-2
> 
DONE



> * Scriptlets: TODO
> - gconf: please adjust the GConf scriptlets according to
> http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GConf  
DONE

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.