[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465636


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #12 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-09-20 11:05:13 EDT ---
(In reply to comment #10)
> > # Don't start the firewall automatically
> > sed -i -e 's,# chkconfig: 2345 99 92,# chkconfig: - 20 80,' firehol.sh
> 
> That's sloppy. sed -i is worse than a clean patch file. If the source file
> changes, your sed transformation no longer applies. Silently. On the contrary,
> a patch would fail and terminate the build. Adding a guard after the sed
> transformation is highly recommended.  

True, didn't come to think of that when I packaged this a year ago when I was a
newcomer in Fedora.


(In reply to comment #11)
> (In reply to comment #9)
> 
> > of https://fedoraproject.org/wiki/Packaging/ReviewGuidelines. And I did all
> > steps of https://fedoraproject.org/wiki/Package_Review_Process which does not
> > state that a comment like "APPROVED" should be written.
> 
> It might be not emphasized enough, but you also need to assign the bug to you
> (the Assigned To field). I just did this for you.  

... and change the status to ASSIGNED, which I just did.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.