[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #67 from Christian Krause <chkr at plauener.de>  2009-09-20 18:16:47 EDT ---
I've looked at the newest package (and especially at the new
subpackage) and unfortunately there are some new issues:

TODO:
The directory %{_datadir}/%{name} is not owned by the javaviewers
subpackage.
Using %{_datadir}/%{name}/ instead of %{_datadir}/%{name}/classes should
fix it.

TODO:
The subpackage should require the fully-versioned main package:
Requires:               %{name} = %{version}-%{release}

TODO:
Regarding the BR for the build of the java parts please follow these
guidelines:
http://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires

It may be debatable whether the "Requires:" are need, but since
the java clients may also be executed outside of the browser, it would
be OK to use them.

TODO:
There are some minor wording/spelling mistakes in the description
of the javaviewers sub-package. I suggest the following:

Summary: VNC clients (java applets)

Description:
The package contains the corresponding java clients for %{name}. They
can be used with any java-enabled browser and provide an easy access to
the server without the need to install software on the client machine.

TODO:
Man pages should not be marked as %doc. (sorry, I've overseen this in
the first review)

TODO:
Please use consistently: %defattr(-,root,root,-)

TODO:
In general the java packaging guidelines encourage the packagers
to build the GCJ AOT bits:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
I've had a quick look and it looks like that it is possible to activate it.

TODO:
Please add the files mentioned by Orcan in #66 to the subpackage as well.

MINOR:
please replace "ln -s" by %%{__ln_s}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.