[Bug 491088] Review Request: rhncfg - Red Hat Network Configuration Client Libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491088


Sandro Mathys <sm at sandro-mathys.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sm at sandro-mathys.ch




--- Comment #1 from Sandro Mathys <sm at sandro-mathys.ch>  2009-09-21 11:08:54 EDT ---
no review, just some remarks:

- I'm sure you can do better with all the %description
- make is missing build-flags
- use %global instead of %define:
http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.