[Bug 466047] Review Request: tcl-mysqltcl - MySQL interface for Tcl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466047





--- Comment #20 from Rene Ploetz <reneploetz at gmx.de>  2009-09-22 13:24:07 EDT ---
Thank you for your reply,

I updated the file locations:
Spec URL: http://www.reneploetz.de/fedora/tcl-mysqltcl.spec
SRPM URL: http://www.reneploetz.de/fedora/tcl-mysqltcl-3.05-3.fc11.src.rpm  

> * Source
>   - SOURCE0 included in your srpm differs from what I could
>     download from the URL written in SOURCE0:
> -----------------------------------------------------------
> 198755 2008-04-06 03:40 mysqltcl-3.05.tar.gz
> 198617 2008-09-24 08:54 tcl-mysqltcl-3.05-2.fc9.src/mysqltcl-3.05.tar.gz
> -----------------------------------------------------------
>
> * License
>   - Actually this is "MIT", not "BSD".
>
> * Version specific BuildRequires
>   - I don't think there is any sense to write tcl-devel version
>     dependency (i.e. >= 8.3.1) where tcl abi dependency is also
>     specified.

FIXED


>  - "-fomit-frame-pointer" makes debugging very difficult and is
>     not allowed on Fedora.

I added "--enable-symbols" to the configure call.

> * %defattr
> -----------------------------------------------------------
> %defattr (0644,root,root,0755)
> %doc README ChangeLog COPYING AUTHORS README-msqltcl doc/mysqltcl.html
> -----------------------------------------------------------
>   - Well, I would recommend to change the permissions of these
>     files at %prep explicitly rather than to use this
>     %defattr hack.
> -----------------------------------------------------------
> %defattr (-,root,root)
> -----------------------------------------------------------
>   - We now recommend %defattr(-,root,root,-)

FIXED


> * tests/ directory
>   - This package contains tests/ directory. If some test program exists,
>     please create %check stage and execute the test program there.

I would like to do that, but unfortunately the tests require that you provide
at least a username for a mysql server. Is there server which could be used by
koji? I wasn't able to find anything about that in the material for packagers.

Koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1698454

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.