[Bug 461849] Review Request: garmintools - Communication tools for Garmin devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461849





--- Comment #8 from Fabian Affolter <fabian at bernewireless.net>  2009-09-22 17:24:35 EDT ---
Thanks Peter for your help with this package.

(In reply to comment #7)
> 
> The 1st message is indicated a possible design flaw in garmintools. You should
> consider asking upstream about it.

The issue was opened on May 2009
http://code.google.com/p/garmintools/issues/detail?id=11

> The 2nd and the 3rd messaged should be fixed. Please remove "devel" from the
> %post and %postun sections (looks like the leftover), and be careful - don't
> forget the %post section which contains "rmmod garmin_gps &>/dev/null || true"

fixed

> The 4th message should be fixed - you accidentally listed file
> %{_libdir}/libgarmintools.so twice - in main package and in devel-subpackage. 

fixed

> - Every binary RPM package (or subpackage) which stores shared library files
> (not just symlinks) in any of the dynamic linker's default paths, must call
> ldconfig in %post and %postun. See my notes, regarding rpmlint messages above.

fixed

> - A Fedora package must not list a file more than once in the spec file's
> %files listings. See my notes, regarding rpmlint messages above.

fixed

> - The package must not own files or directories already owned by other
> packages. Unfortunately, main package owns /etc/udev/rules.d and
> /etc/modprobe.d
> Please use the correct form (note the asterisk mark at the end of the
> strings)):
> 
> %config(noreplace) %{_sysconfdir}/udev/rules.d/*
> %config(noreplace) %{_sysconfdir}/modprobe.d/*

fixed

rpath was removed.

rpmlint output:
[fab at laptop016 SRPMS]$ rpmlint garmintools-0.10-2.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab at laptop016 x86_64]$ rpmlint garmintools*
garmintools.x86_64: W: shared-lib-calls-exit /usr/lib64/libgarmintools.so.4.2.0
exit at GLIBC_2.2.5
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Updated files
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/garmintools.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/garmintools-0.10-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.